chore(policy): run status reconcilation at fixed interval #13384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
commented
Nov 24, 2024
olix0r
force-pushed
the
ver/policy-log-reconcile
branch
3 times, most recently
from
9fee7da to
128c737
Compare
olix0r
force-pushed
the
ver/policy-log-noise
branch
3 times, most recently
from
cbf6550 to
fb99223
Compare
olix0r
force-pushed
the
ver/policy-log-reconcile
branch
from
128c737 to
6eb80ef
Compare
olix0r
force-pushed
the
ver/policy-log-noise
branch
2 times, most recently
from
bd88260 to
5e3ff63
Compare
olix0r
force-pushed
the
ver/policy-log-reconcile
branch
3 times, most recently
from
0dc68be to
f6ac870
Compare
olix0r
commented
Nov 25, 2024
olix0r
force-pushed
the
ver/policy-log-noise
branch
from
5e3ff63 to
712c9bd
Compare
olix0r
force-pushed
the
ver/policy-log-reconcile
branch
from
f6ac870 to
f6e4b2e
Compare
cratelyn
approved these changes
Nov 25, 2024
olix0r
force-pushed
the
ver/policy-log-noise
branch
from
712c9bd to
9bd5387
Compare
olix0r
force-pushed
the
ver/policy-log-reconcile
branch
2 times, most recently
from
16d4327 to
422ce62
Compare
The status reconcilation loop runs differently than it seems is intended (based on the original DEBUG logging): reconcilation is triggered every time that the lease updates, even when there is no change in leadership. The code seems to assume that the lease only updates when leadership changes, but this is not the case. This commit updates the status reconcilation loop to use a timer. The timer is reset when leadership is acquired so that reconcilation is triggered at a fixed interval.
olix0r
force-pushed
the
ver/policy-log-reconcile
branch
from
422ce62 to
00b0a95
Compare
adleong
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status reconcilation loop runs differently than it seems is intended (based on the original DEBUG logging): reconcilation is triggered every time that the lease updates, even when there is no change in leadership. The code seems to assume that the lease only updates when leadership changes, but this is not the case.
This commit updates the status reconcilation loop to use a timer. The timer is reset when leadership is acquired so that reconcilation is triggered at a fixed interval.